Fix Heltec v2 pinmap and add more Heltec pinmaps

[manuelbl]

As described in #463 I've fixed the invalid Heltec Wifi Lora32 v2 pinmap. Additionally, I've added pinmaps for Heltec Wifi Lora v1 and Heltec Wireless Stick boards.

The changes have been tested with:

• Heltec Wifi Lora v1
• Heltec Wifi Lora v2
• ttgo Lora32 v1

I would have additional ttgo boards (ttgo LoRa32 v2 and v2.1) to test but unfortunately they do not have board definitions in the Arduino framework. So a predefined pinmap cannot be automatically selected.

I've also tried to add the ttgo T-Beam board. But it uses the macro ARDUINO_T-beam, which is invalid due to the dash. And I was unable to find a working macro expression to select it. So I had to omit it. It would have worked on PlatformIO as they changed the macro to ARDUINO_T_beam.

[terrillmoore]

Looks great, thanks for your contribution!

[rthille]

I ran into an issue when trying to use this code on my Heltec WiFi LoRA ESP32 (v2), and it turned out that the Arduino IDE was defining ARDUINO_WIFI_LORA_32_V2, not ARDUINO_HELTEC_WIFI_LORA_32_V2 (no HELTEC). I assume that's because the boards.txt file here: https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series/blob/master/esp32/boards.txt#L186 specifies wifi_lora_32_V2.build.board=WIFI_LORA_32_V2.
The other thing that's close the Heltec package seems to define for that board is here: https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series/blob/master/esp32/variants/wifi_lora_32_V2/pins_arduino.h#L6 (#define WIFI_LoRa_32_V2 true).
I've never really got deep into Arudino, but am I missing something here? Should I be setting something somewhere in the IDE, or defining ARDUINO_HELTEC_WIFI_LORA_32_V2 in my own sketch or build arguments somewhere?
Thanks!

[terrillmoore]

It comes from boards.txt. Since this worked at one time, my guess is that the boards.txt file changed. We can add the checks for the new constant. (You can patch yourself by changing the file here to add ARDUINO_WIFI_LoRa_32_V2 here, and also in the .h file:

arduino-lmic/src/hal/getpinmap_thisboard.cpp

Line 60 in 540034c

#elif defined(ARDUINO_HELTEC_WIFI_LORA_32_V2) || defined(ARDUINO_TTGO_LoRa32_V1)

[rthille]

Thanks for the quick reply. I got my board working by substituting s/ARDUINO_HELTEC_WIFI_/ARDUINO_WIFI_/in the two files in arduino-lmic/src/hal/..., but I wondered what the "right" solution was, since it seemed to work for everyone but me (I didn't see any posts anywhere with the same issue I was having), but computers are often like that for me :-).