bugfix: add missing pinmode initialization in hal_interrupt_init() #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinmode initialization is missing in hal_interrupt_init(). Without the interrupt driven timestamping mode does not work (tested on ESP32 hardware). Added just this one extra line and it worked! :-)
|
Sure. I currently have no test case for interrupt driven, so no surprise that this was missed. I suspect that on AVR32, the only other place I've heard of this being used, the pin mode is INPUT by default. I suppose I should get a few ESP32s for the device zoo -- open to recommendations. And should consider doing this on the Murata modules. But so close to completing the pre-cert stuff that I don't want to get distracted. |
|
Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinmode initialization is missing in hal_interrupt_init() for the interrupt driven timestamping mode.
Without pinmode initialization the interrupt driven timestamping mode does not work (tested on ESP32 hardware). Added just this one extra line and heureka it worked! :-)