Fix #333: Emit EV_TXCOMPLETE earlier #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when no packet was received in RX2, there would be a 3-5 second delay (for EU868) before calling `processDnData()` and emitting EV_TXCOMPLETE. This was the `DNW2_SAFETY_ZONE` to prevent a subsequent TX to collide with a downlink packet that was ongoing but not locked on to. With this change, `txDelay()` is used to still delay the subsequent TX, without delaying the `EV_TXCOMPLETE` event, which allows battery-powered devices that wait for this event before sleeping to get an extra 3-5 seconds of sleep for each transmitted packet, improving battery life. Closes: upstream issue 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when no packet was received in RX2, there would be a 3-5 second
delay (for EU868) before calling
processDnData()and emittingEV_TXCOMPLETE. This was the
DNW2_SAFETY_ZONEto prevent a subsequentTX to collide with a downlink packet that was ongoing but not locked on
to.
With this change,
txDelay()is used to still delay the subsequent TX,without delaying the
EV_TXCOMPLETEevent, which allows battery-powereddevices that wait for this event before sleeping to get an extra 3-5
seconds of sleep for each transmitted packet, improving battery life.
Closes: upstream issue 16