Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #38: Properly initialize NSS, RXTX, RST pins #160

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

manuelbl
Copy link

Here's a fix for issue #38 (Need to initialize nss pin to HIGH).

  • writeDigital is deliberately called before pinMode(..., OUTPUT) to avoid spikes on the output pin. This pattern should work on all Arduino implementations.
  • RXTX is initialized to RX mode.
  • RST is set to floating. That's the same state the pin is in after the reset has been executed. Before it was implicit set to LOW.

@terrillmoore
Copy link
Member

terrillmoore commented Oct 28, 2018

Looks good, thanks. However, users must be aware that (1) this may increase power consumption, as there may be module-specific pull-ups or pull-downs on some signals; (2) this doesn't solve the problem of setting NSS high in those situations where the LMIC hasn't been initialized. I'm not sure whether #38 might have been reported in that context. We also need an update to README.md, which I'll add manually after the merge.

@terrillmoore terrillmoore merged commit 48d154c into mcci-catena:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants