Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heltec Wifi LoRa v2 (ESP32) fix for printf #146

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

EtoTen
Copy link

@EtoTen EtoTen commented Oct 9, 2018

Fixing #140 tested with Heltec Wifi LoRa v2 (ESP32) and BSFrance LoRa32u4 II

Fixing mcci-catena#140 tested with Heltec Wifi LoRa v2 (ESP32) and BSFrance LoRa32u4 II
@terrillmoore
Copy link
Member

Looks good, thanks!

At some point in the future I'd like to refactor all this to reduce conditional compiles in code. Would be nice to add a CI test for this. @lunarHonour if you can tell me the BSP to use and your debug configuration, it's pretty easy to add.

@terrillmoore terrillmoore merged commit c3aa460 into mcci-catena:master Oct 13, 2018
@EtoTen EtoTen deleted the patch-1 branch October 14, 2018 01:08
@EtoTen
Copy link
Author

EtoTen commented Oct 14, 2018

Looks good, thanks!

At some point in the future I'd like to refactor all this to reduce conditional compiles in code. Would be nice to add a CI test for this. @lunarHonour if you can tell me the BSP to use and your debug configuration, it's pretty easy to add.

Thanks for merging it!
I am using this BSP: https://github.com/espressif/arduino-esp32 for the Heltec Wifi Lora 32 v2. Not sure what you mean by Debug configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants