Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In function 'LMICeu868_nextTx': 'feasibleMap' may be used uninitialized #730

Closed
cyberman54 opened this issue May 8, 2021 · 1 comment
Closed
Assignees
Labels

Comments

@cyberman54
Copy link

cyberman54 commented May 8, 2021

With refactoring code in 3.99.0-2 compiler throws warning:

In function 'LMICeu868_nextTx':
src/lmic/lmic_eu868.c:304:29: warning: 'feasibleMap' may be used uninitialized in this function
feasibleMap |= chnlBit;

And, indeed, feasibleMap seems to be uninitialized in all LMIC<$country>_nextTx() functions?

@terrillmoore
Copy link
Member

Thanks!

Guess I need to turn up warnings in my default setup. Serves me right for not enabling this while I was tweaking the BSP package.

feasibleMap only appears in LMICeu868_nextTx() and LMICas923_nextTx(). I'll post a patch.

terrillmoore added a commit that referenced this issue May 8, 2021
terrillmoore added a commit that referenced this issue May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants