Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generic Application Block to FRAM Map #247

Merged

Conversation

lthiery
Copy link
Contributor

@lthiery lthiery commented Feb 11, 2020

This is intended to allow a user to store more or less arbitrary data an FRAM slot. It would be up to the application layer to derive and determine validity of the data in the block.

@lthiery lthiery requested a review from terrillmoore February 11, 2020 19:17
Copy link
Member

@terrillmoore terrillmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, if not doing an immediate release, we should bump the lib header version to 0.18.0.10 or something, so that a careful client can know whether this is in the library. However, if we want to do a release so this shows up in the library manager (which I imagine we do), we can leave version as it is and do a release as 0.18.1.

@lthiery
Copy link
Contributor Author

lthiery commented Feb 11, 2020

@terrillmoore did i do it right for immediate release?

@terrillmoore
Copy link
Member

Hi, there's a release checklist in the tickets marked 'release'. See #246 for an example. Need to update library.properties, README.me, and the version in the header file (for introspection).

@terrillmoore
Copy link
Member

(I'd do the changes, but I have to run a meeting for the next two hours.)

@lthiery
Copy link
Contributor Author

lthiery commented Feb 11, 2020

I think I did it? But I have referenced this PR in the release history while it seems like you normally do issues. Should I create an issue about this PR or this fine?

@terrillmoore
Copy link
Member

Looks right to me! I'll merge now and release.

@terrillmoore terrillmoore merged commit 85c010c into mcci-catena:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants