Fix issue 129; check RTC clock source and set prescaler value #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| else | ||
| { | ||
| /* use HSE clock -- not defined HSE input clock value */ |
There was a problem hiding this comment.
Can we figure out what's needed for HSE so we don't have a dangling path? Is this needed for anything?
There was a problem hiding this comment.
Currently HSE clock (PH0_OSC_IN) is connected with TCXO_OUT pin.
I am not sure what's clock rate of TCXO_OUT pin.
It looks for me we can't use HSE clock as RTC clock.
There was a problem hiding this comment.
- This should be in a comment: we don't support use of HSE as RTC because it's connected to TCXO_OUT, and that's controlled by the LoRaWAN software.
- I think we should use gLog.printf(), not use Serial directly. Serial.print will hang if there's no USB and there's not even rudimentary debug logging control.
There was a problem hiding this comment.
I updated comment as suggested and use gLog.printf().
terrillmoore
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #129 fix.