Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 24-bit mode for LargeWhite light in Si1133 driver #288

Closed
dhineshkumarmcci opened this issue Apr 3, 2021 · 0 comments
Closed

Disable 24-bit mode for LargeWhite light in Si1133 driver #288

dhineshkumarmcci opened this issue Apr 3, 2021 · 0 comments
Assignees
@dhineshkumarmcci
Labels
bug

Comments

@dhineshkumarmcci
Copy link
Member

The LargeWhite configuration is set to 24 bit mode by default, this has to be set to false by default.

Catena-Arduino-Platform/src/lib/Catena_Si1133.cpp

Lines 85 to 91 in 3f23add

Catena_Si1133::ChannelConfiguration_t()
.setAdcMux(Catena_Si1133::InputLed_t::LargeWhite)
.setSwGainCode(7)
.setHwGainCode(4)
.setPostShift(1)
.set24bit(1)
.setCounter(Catena_Si1133::ChannelConfiguration_t::CounterSelect_t::MeasCount2),

@dhineshkumarmcci dhineshkumarmcci self-assigned this Apr 3, 2021
dhineshkumarmcci added a commit that referenced this issue Apr 3, 2021
@dhineshkumarmcci
Fix #288: set swgain and hwgain to 0 by default
8f87221
dhineshkumarmcci added a commit that referenced this issue Apr 5, 2021
@dhineshkumarmcci
Fix #288: set decimation rate to 1
379ff93
terrillmoore added a commit that referenced this issue Apr 5, 2021
@terrillmoore
Merge pull request #291 from mcci-catena/issue288
f4a02c3 
Fix #288: incorporate changes from issue288 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhineshkumarmcci dhineshkumarmcci

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhineshkumarmcci