Improve comment and use gLog.printf

mcci-catena · Jul 19, 2019 · 407dd81 · 407dd81
1 parent abbb9e0
commit 407dd81
Showing 1 changed file with 37 additions and 9 deletions.
diff --git a/src/lib/stm32/stm32l0/CatenaStm32L0Rtc.cpp b/src/lib/stm32/stm32l0/CatenaStm32L0Rtc.cpp
@@ -16,6 +16,8 @@ Copyright notice:
 #ifdef ARDUINO_ARCH_STM32
 
 #include "CatenaStm32L0Rtc.h"
+#include "Catena_Log.h"
+
 using namespace McciCatena;
 
 /****************************************************************************\
@@ -147,10 +149,16 @@ bool CatenaStm32L0Rtc::begin(bool fResetTime)
 		}
 	else
 		{
-		/* use HSE clock -- not defined HSE input clock value */
-//		this->m_hRtc.Init.AsynchPrediv = 64 - 1; /* 40kHz / 64 = 625Hz */
-//		this->m_hRtc.Init.SynchPrediv = 625 - 1; /* 625Hz / 625 = 1Hz */
-		Serial.println("RTC clock use HSE and not supported yet!");
+		/*
+		|| use HSE clock --
+		|| we don't support use of HSE as RTC because it's connected to
+		|| TCXO_OUT, and that's controlled by the LoRaWAN software.
+		*/
+		gLog.printf(
+			gLog.kError,
+			"?CatenaStm32L0Rtc::begin:"
+			" HSE can not be used for RTC clock!\n"
+			);
 		return false;
 		}
 
@@ -164,7 +172,11 @@ bool CatenaStm32L0Rtc::begin(bool fResetTime)
 
 	if (HAL_RTC_Init(&this->m_hRtc) != HAL_OK)
 		{
-		Serial.println("HAL_RTC_Init() failed");
+		gLog.printf(
+			gLog.kError,
+			"?CatenaStm32L0Rtc::begin:"
+			" HAL_RTC_Init() failed\n"
+			);
 		return false;
 		}
 
@@ -186,7 +198,11 @@ bool CatenaStm32L0Rtc::begin(bool fResetTime)
 			RTC_FORMAT_BIN
 			) != HAL_OK)
 			{
-			Serial.println("HAL_RTC_SetTime() failed");
+			gLog.printf(
+				gLog.kError,
+				"?CatenaStm32L0Rtc::begin:"
+				" HAL_RTC_SetTime() failed\n"
+				);
 			return false;
 			}
 
@@ -202,7 +218,11 @@ bool CatenaStm32L0Rtc::begin(bool fResetTime)
 			RTC_FORMAT_BIN
 			) != HAL_OK)
 			{
-			Serial.println("HAL_RTC_SetDate() failed");
+			gLog.printf(
+			gLog.kError,
+				"?CatenaStm32L0Rtc::begin:"
+				" HAL_RTC_SetDate() failed\n"
+				);
 			return false;
 			}
 
@@ -261,7 +281,11 @@ bool CatenaStm32L0Rtc::SetTime(const CalendarTime *pNow)
 
 	if (HAL_RTC_SetTime(&this->m_hRtc, &Time, RTC_FORMAT_BIN) != HAL_OK)
 		{
-		Serial.println("HAL_RTC_SetTime() failed");
+		gLog.printf(
+			gLog.kError,
+			"?CatenaStm32L0Rtc::begin:"
+			" HAL_RTC_SetTime() failed\n"
+			);
 		return false;
 		}
 
@@ -272,7 +296,11 @@ bool CatenaStm32L0Rtc::SetTime(const CalendarTime *pNow)
 
 	if (HAL_RTC_SetDate(&this->m_hRtc, &Date, RTC_FORMAT_BIN) != HAL_OK)
 		{
-		Serial.println("HAL_RTC_SetDate() failed");
+		gLog.printf(
+			gLog.kError,
+			"?CatenaStm32L0Rtc::begin:"
+			" HAL_RTC_SetDate() failed\n"
+			);
 		return false;
 		}