Summary comment must be resolved by a hand before pull request could be merged.

[exxbrain]

Summary comment must be resolved by a hand before pull request could be merged. So now pull request decoration at least in gitlab negatively affects a merge process when pull request couldn't be merged automatically after successful completion of a pipeline.

Steps to reproduce the behavior:

1. Navigate to your gitlab project’s settings page, select the Only allow merge requests to be merged if all threads are resolved check box and hit Save for the changes to take effect.
2. Make merge request without issues and click a button "Merge when pipeline succeeds"

Expected behavior
Pull request should be automatically merged.

Screenshots

Software Versions

• Gitlab
• SonarQube Version: 7.9.2 (build 30863)
• Plugin Version: 1.2.1-RC3

Suggestion
I think that it will be good to resolve summary comment thread automatically if there are no issues found.

[mc1arke]

This sounds like a feature request rather than a bug: you've enabled decoration, but your current pipeline then prevents decorated MRs from being auto-merged. I presume you're asking for the summary comment to posted in another way?

[kortov]

I guess it's similar to #97

[exxbrain]

I presume you're asking for the summary comment to posted in another way?

If it is possible then yes. But current solution is nice as well except the case when there are no issues.

[exxbrain]

I guess it's similar to #97

@kortov I think you are right. But I posted this bug because current functionality is conflicting with gitlab settings. The solution may be the same: just don't post a comment with zero issues, or as @mc1arke said - in another way.

[exxbrain]

Gitlab provides 2 endpoints - discussions and notes:

1. https://docs.gitlab.com/ee/api/discussions.html
2. https://docs.gitlab.com/ee/api/notes.html.

Now we use discussions. I think we can try notes. Probably it will be enough to fix both issues. Also I see some as I think useful flags: resolvable, resolved, noteable_id.

[kortov]

Let's sum up all of this. I guess it's all should work like checks on github - if check is failed - it prevents merge, and if passed then no matter what the check may write in comments (e.g codecov) it doesn't prevent merge.
So I guess the plugin should work like this. If quality gate passed - write something not preventing merge (note, resolved thread, autoresolved by plugin thread etc)
I guess this is not implemented now but there are options in gitlab api to work it out and we only should pick the suitable one. Am I right?

[exxbrain]

Yes. We need to solve 2 requirements by picking options from gitlab api for the case when no issues found:

1. No notification.
2. Note (discussion) should be resolved. (This will allow auto-merge).

By the way

If quality gate passed

This doesn't mean that there are no issues. I think code reviewer should decide in this case, i.e. summary comment better not to be resolved from my point of view.

Also I think discussion is not an option because I don't know what I should discuss under summary comment.

[mfolnovic]

From my point of view, it makes sense to use Discussion API for issues and Notes API for summary. Which is probably what you thought, right?

[exxbrain]

The fix for the problem is in the #126.

[bmaehr]

Implemented here: https://github.com/bmaehr/sonarqube-community-branch-plugin/blob/editComments/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/gitlab/GitlabServerPullRequestDecorator.java

[MCMicS]

Change #226 will auto resolve the discussion if quality gates passes