Skip to content

Commit

Permalink
Merge pull request #102 from mbuchthal/review-refactor
Browse files Browse the repository at this point in the history
Review refactor
  • Loading branch information
mbuchthal committed Sep 23, 2015
2 parents 00f6518 + 668f5aa commit 68ba37e
Show file tree
Hide file tree
Showing 6 changed files with 55 additions and 69 deletions.
1 change: 0 additions & 1 deletion public/sass/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
@import "partials/best-way";

@import "partials/paragraphs";
@import "partials/headings";

@import "partials/nav";

Expand Down
24 changes: 2 additions & 22 deletions public/sass/modules/_icon-styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,6 @@
font-weight: normal;
font-style: normal;
}
@font-face {
font-family: 'icomoon';
src:url('fonts/icomoon.eot?log50y');
src:url('fonts/icomoon.eot?#iefixlog50y') format('embedded-opentype'),
url('fonts/icomoon.ttf?log50y') format('truetype'),
url('fonts/icomoon.woff?log50y') format('woff'),
url('fonts/icomoon.svg?log50y#icomoon') format('svg');
font-weight: normal;
font-style: normal;
}

%icon-fonts {
font-family: 'icomoon';
Expand Down Expand Up @@ -115,10 +105,7 @@ $icons: (box "\e600") (flask "\e601") (phone "\e603") (mail "\e604") (location "
font-size: 2em;
}
// // App Reviews
.icon-quotes {
// margin: 0 auto;
color: $color-text-light;
}

// // App Support
// .icon-location:before {
// content: "\e605";
Expand All @@ -129,14 +116,7 @@ $icons: (box "\e600") (flask "\e601") (phone "\e603") (mail "\e604") (location "
// .icon-mail:before {
// content: "\e604";
// }
.focus-arrow:before {
content: " ";
display: inline-block;
width: 42px;
height: 83px;
background-image: url("../assets/arrow.svg");
background-repeat: no-repeat;
}




12 changes: 9 additions & 3 deletions public/sass/partials/_carousel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
// carousel dots
ol {
position: absolute;
width: 20%;
width: 30%;
top: 0;
right: 40%;
right: 32%;
text-align: center;
@media screen and (min-width: 50em) {
width: 1%;
Expand All @@ -22,13 +22,19 @@
}
.dot {
display: inline-block;
margin: 0.25em;
margin: 0.25em 0.5em;
padding: 0;
border: 1px solid $color-link-button-background;
border-radius: 50%;
height: 0.5em;
width: 0.5em;
background-color: transparent;
&:first-child {
margin-left: 0.75em;
@media screen and (min-width: 50em) {
margin-left: 0;
}
}
&.active {
background-color: $color-link-button-background;
}
Expand Down
20 changes: 0 additions & 20 deletions public/sass/partials/_headings.scss

This file was deleted.

4 changes: 0 additions & 4 deletions public/sass/partials/_paragraphs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ h1 {
}

h2 {
.why-choose & {
text-align: center;
font-size: 150%;
}
.feature-image-wrapper & {
color: $color-text-light;
font: $head-big-medium-font;
Expand Down
63 changes: 44 additions & 19 deletions public/sass/partials/_section.scss
Original file line number Diff line number Diff line change
@@ -1,21 +1,60 @@
.why-choose {
// position: relative;
padding-bottom: 2em;
h2 {
margin-top: 1em;
font: $head-big-light-font;
font-size: 150%;
color: $color-text-light;
text-align: center;
}
.img-carousel {
position: relative;
margin: 0 auto;
h4 {
padding-top: 0.5em;
padding-bottom: 1em;
font: $head-x-small-light-font;
color: $color-text-light;
text-align: center;
@media screen and (min-width: 50em) {
width: 80%;
padding-bottom: 3em;
}
}
.icon-quotes {
color: $color-text-light;
}
.sm-semicircular-eclipse-border {
margin: 0 auto;
.icon-quotes {
margin-top: 1em;
}
}
.arrow-position-wrapper {
position: relative;
width: 50%;
margin: 0 25%;
}
.focus-arrow {
position: absolute;
bottom: 0;
right: -3em;
@media screen and (min-width: 50em) {
bottom: 1.5em;
right: 5em;
}
}
.focus-arrow:before {
content: " ";
display: inline-block;
width: 42px;
height: 83px;
background-image: url("../assets/arrow.svg");
background-repeat: no-repeat;
}
.img-carousel {
position: relative;
margin: 0 auto;
@media screen and (min-width: 50em) {
width: 80%;
}
}
}

.amazing-features {
Expand All @@ -36,18 +75,4 @@

}
}
.arrow-position-wrapper {
position: relative;
width: 50%;
margin: 0 25%;
.focus-arrow {
position: absolute;
bottom: 0;
right: -3em;
@media screen and (min-width: 50em) {
bottom: 1.5em;
right: 5em;
}
}
}

0 comments on commit 68ba37e

Please sign in to comment.