feat(asana): support state transition from draft -> ready_for_review … #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with reviewers already set
meagharty
requested review from
a team,
nlwstein and
bklebe
and removed request for
a team
|
Adding @bklebe since Nick is OOO |
nlwstein
approved these changes
Feb 6, 2024
| @@ -70,7 +70,7 @@ jobs: | |||
| move-to-in-review-asana-ticket-job: | |||
| runs-on: ubuntu-latest | |||
| needs: check-for-secrets | |||
| if: inputs.review-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && github.event.action == 'review_requested' && !github.event.pull_request.draft && github.actor != 'dependabot[bot]' | |||
| if: inputs.review-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && (github.event.action == 'review_requested' || github.event.action == 'ready_for_review' && (toJson(github.event.pull_request.requested_reviewers) != '[]' || toJson(github.event.pull_request.requested_teams) != '[]')) && !github.event.pull_request.draft && github.actor != 'dependabot[bot]' | |||
There was a problem hiding this comment.
This is entirely not your fault but I wish they gave us a cleaner way to evaluate and work with arrays. The hack is clever, though 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with reviewers already set
Asana ticket: [Github -> Asana] Move tickets back into "In Review" when a PR that was converted to draft is marked ready for review
Requires Action using this workflow to listen for the pull_request
ready_for_revieweventhttps://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request