-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: only run Asana jobs if the secrets are present
This avoids failures when running on PRs from forks. We do it in this convoluted way because you can't access secrets directly from `if` blocks: actions/runner#520 The key differences between this and #14 are: - typo: should be `outputs` in the `if` blocks - more explicity check for the secrets in a Bash script, so we can see the output - use `yes` instead of `true` as the value to more clearly distinguish the value from a true boolean
- Loading branch information
1 parent
c550d6d
commit 82ff490
Showing
1 changed file
with
17 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,9 +29,21 @@ on: | |
required: false | ||
description: GitHub secret that Asana uses to fetch PR information. | ||
jobs: | ||
check-for-secrets: | ||
runs-on: ubuntu-latest | ||
output: | ||
has-asana-token: ${{ steps.outputs.outputs.has-asana-token }} | ||
has-github-secret: ${{ steps.output.outputs.has-github-secret }} | ||
steps: | ||
- id: outputs | ||
run: | | ||
[ -n "${{ secrets.asana-token }}" ] && echo "has-asana-token=yes" >> "$GITHUB_OUTPUT" | ||
[ -n "${{ secrets.github-secret }}" ] && echo "has-github-secret=yes" >> "$GITHUB_OUTPUT" | ||
cat $GITHUB_OUTPUT | ||
move-to-merged-asana-ticket-job: | ||
runs-on: ubuntu-latest | ||
if: inputs.merged-section != '' && github.event.pull_request.merged == true && github.actor != 'dependabot[bot]' | ||
needs: check-for-secrets | ||
if: inputs.merged-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && github.event.pull_request.merged == true && github.actor != 'dependabot[bot]' | ||
steps: | ||
- name: Move ticket on merge | ||
uses: mbta/[email protected] | ||
|
@@ -42,7 +54,8 @@ jobs: | |
mark-complete: ${{ inputs.complete-on-merge }} | ||
move-to-in-review-asana-ticket-job: | ||
runs-on: ubuntu-latest | ||
if: inputs.review-section != '' && github.event.action == 'review_requested' && github.actor != 'dependabot[bot]' | ||
needs: check-for-secrets | ||
if: inputs.review-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && github.event.action == 'review_requested' && github.actor != 'dependabot[bot]' | ||
steps: | ||
- name: Move ticket on review requested | ||
uses: mbta/[email protected] | ||
|
@@ -52,8 +65,9 @@ jobs: | |
target-section: ${{ inputs.review-section }} | ||
create-asana-attachment-job: | ||
runs-on: ubuntu-latest | ||
needs: check-for-secrets | ||
name: Create pull request attachments on Asana tasks | ||
if: inputs.attach-pr && github.actor != 'dependabot[bot]' | ||
if: inputs.attach-pr && needs.check-for-secrets.outputs.has-github-secret == 'yes' && github.actor != 'dependabot[bot]' | ||
steps: | ||
- name: Create pull request attachments | ||
uses: Asana/[email protected] | ||
|