Skip to content

Commit

Permalink
fix(asana): Fix In Development with racing PR open and PR review_requ…
Browse files Browse the repository at this point in the history
…ested
  • Loading branch information
meagharty committed Jan 30, 2024
1 parent 1c8f002 commit 20579c6
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/asana.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ on:
type: string
required: false
description: The Asana project section for tickets with PRs that are in development. Requires secrets.asana-token.
merged-section:
type: string
required: false
description: The Asana project section for tickets with PRs that have been merged. Requires secrets.asana-token.
review-section:
type: string
required: false
description: The Asana project section for tickets with PRs that have a review requested. Requires secrets.asana-token.
merged-section:
type: string
required: false
description: The Asana project section for tickets with PRs that have been merged. Requires secrets.asana-token.
complete-on-merge:
type: boolean
default: false
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
move-to-in-development-asana-ticket-job:
runs-on: ubuntu-latest
needs: check-for-secrets
if: inputs.development-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && (github.event.action == 'opened' || github.event.action == 'reopened' || github.event.action == 'converted_to_draft') && github.actor != 'dependabot[bot]'
if: inputs.development-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && (github.event.action == 'opened' || github.event.action == 'reopened' || github.event.action == 'converted_to_draft' || github.event.action == 'edited') && (toJson(github.event.pull_request.requested_reviewers) == '[]' && toJson(github.event.pull_request.requested_teams) == '[]' || github.event.pull_request.draft) && github.actor != 'dependabot[bot]'
steps:
- name: Move ticket to In Development
uses: mbta/[email protected]
Expand All @@ -70,7 +70,7 @@ jobs:
move-to-in-review-asana-ticket-job:
runs-on: ubuntu-latest
needs: check-for-secrets
if: inputs.review-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && github.event.action == 'review_requested' && github.actor != 'dependabot[bot]'
if: inputs.review-section != '' && needs.check-for-secrets.outputs.has-asana-token == 'yes' && github.event.action == 'review_requested' && !github.event.pull_request.draft && github.actor != 'dependabot[bot]'
steps:
- name: Move ticket on review requested
uses: mbta/[email protected]
Expand Down

0 comments on commit 20579c6

Please sign in to comment.