Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player join/leave webhook #973

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Player join/leave webhook #973

merged 4 commits into from
Oct 30, 2024

Conversation

mbround18
Copy link
Owner

@mbround18 mbround18 commented Oct 3, 2024 •
edited
Loading

Description

Contributions

  • Added webhook to discord file
  • Added line in log parse looking for join/leave

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 linked an issue Oct 3, 2024 that may be closed by this pull request
Webhook for Join/Leave #972
Closed
@mbround18 mbround18 added odin Tag if theres an issue with odin patch Increment the patch version when merged release Create a release when this pr is merged labels Oct 3, 2024
@mbround18
Copy link
Owner Author

I am still thinking though how to best implement this, in the logs they dont really have great messages that are succinct. im thinking of creating a players.list in the game folder that tracks visitors

@mbround18
Copy link
Owner Author

@andrewgdunn im sorry this took so long, getting back into it now.

Got some good progress!

image

@andrewgdunn
Copy link

I love it! Thanks for being willing to prototype this!

@mbround18 mbround18 added the canary Use this to release a canary version for testing label Oct 23, 2024
@mbround18
Copy link
Owner Author

@andrewgdunn if u wanna give it a play test the docker image is

mbround18/odin:sha-d23b102

and the flag to enable it is

PLAYER_EVENT_NOTIFICATIONS=1

@andrewgdunn
Copy link

Works great!

@mbround18 mbround18 marked this pull request as ready for review October 30, 2024 03:23
@mbround18 mbround18 merged commit c390f6d into main Oct 30, 2024
17 of 27 checks passed
@mbround18 mbround18 deleted the 972-webhook-for-joinleave branch October 30, 2024 03:24
@mbround18
Copy link
Owner Author

Thank you @andrewgdunn burn in test is complete, this has been merged :) this is available on

https://github.com/mbround18/valheim-docker/releases/tag/v3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
canary Use this to release a canary version for testing odin Tag if theres an issue with odin patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook for Join/Leave
2 participants
@mbround18 @andrewgdunn