Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of concerns for docker files and building #41

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Separation of concerns for docker files and building #41

merged 2 commits into from
Feb 11, 2021

Conversation

mbround18
Copy link
Owner

Description

Contributions

  • Changed Odin to be its own container
  • Updated Valheim container to not be building odin

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

Co-authored-by: @aarontc

@mbround18 mbround18 added the docker Tag if its related to docker label Feb 11, 2021
@mbround18 mbround18 merged commit cb31cd0 into main Feb 11, 2021
@mbround18 mbround18 deleted the mbround18/seperation-of-concern branch February 11, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker Tag if its related to docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbround18