Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtract 1 from AUTO_BACKUP_DAYS_TO_LIVE and prune before creating backup #290

Merged
merged 5 commits into from
Mar 20, 2021
Merged

Subtract 1 from AUTO_BACKUP_DAYS_TO_LIVE and prune before creating backup #290

merged 5 commits into from
Mar 20, 2021

Conversation

ikaruswill
Copy link
Contributor

@ikaruswill ikaruswill commented Mar 16, 2021 •
edited
Loading

Fixes #289

Description

Contributions

  • I removed + on auto-backup script -mtime parameter as it should be interpreted as an exact match between AUTO_BACKUP_DAYS_TO_LIVE and the calculated integer-truncated value.

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18
Copy link
Owner

You should avoid force pushing as it can force rewrite of history in your PRs.

@mbround18
Copy link
Owner

Have you tested this change locally?

@ikaruswill
Copy link
Contributor Author

ikaruswill commented Mar 17, 2021 •
edited
Loading

Force pushing was in my intentions as the commit metadata reflected my old email. Nonetheless it's just one commit and a one-line change, so it shouldn't matter.

I've tested it with a local docker build, builds fine, cleans up backups fine. Also checked on the exec shell of a running latest container as shown in the Proof of concept section in the issue.

Edit: @LovecraftianHorror has some valid points on handling the case of backups older than TTL if we remove the +. Let me think about a workaround first.

@ikaruswill
Revert "Remove + from find -mtime"
e76f970 
This reverts commit 08af441.
@ikaruswill
Subtract 1 from AUTO_BACKUP_DAYS_TO_LIVE
2197119 
Before passing to find mtime argument as +${AUTO_BACKUP_DAYS_TO_LIVE}
Also add log message to indicate old backup removal
@ikaruswill
Move backup creation step to after backups are pruned
41755f1 
To handle case where AUTO_BACKUP_DAYS_TO_LIVE == 0 deletes all backups including latest.
New behaviour would be to only retain latest backup and delete all others.
@ikaruswill
Fix typo from testing
dc9b90e 
Also remove duplicated log message
@ikaruswill
Copy link
Contributor Author

Done. Ready for review.

@ikaruswill
Copy link
Contributor Author

ikaruswill commented Mar 17, 2021 •
edited
Loading

Testing on my own server instance:
Before change, /home/steam/backups:

root@valheim-59978997b9-5kv96:/home/steam/backups# ls -laht
total 6.0G
drwxr-xr-x 2 steam steam  28K Mar 17 12:45 .
-rw-r--r-- 1 steam steam  32M Mar 17 12:45 20210317-124501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:30 20210317-123001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:15 20210317-121501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:00 20210317-120001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:45 20210317-114501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:30 20210317-113001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:15 20210317-111501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:00 20210317-110001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:45 20210317-104501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:30 20210317-103001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:15 20210317-101501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:00 20210317-100001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:45 20210317-094501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:30 20210317-093001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:15 20210317-091501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:00 20210317-090001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:45 20210317-084501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:30 20210317-083001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:15 20210317-081501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:00 20210317-080001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:45 20210317-074501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:30 20210317-073001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:15 20210317-071501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:00 20210317-070001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:45 20210317-064501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:30 20210317-063001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:15 20210317-061501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:00 20210317-060001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:45 20210317-054501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:30 20210317-053001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:15 20210317-051501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:00 20210317-050001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:45 20210317-044501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:30 20210317-043001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:15 20210317-041501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:00 20210317-040001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:45 20210317-034501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:30 20210317-033001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:15 20210317-031501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:00 20210317-030001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:45 20210317-024501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:30 20210317-023002-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:15 20210317-021501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:00 20210317-020001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:45 20210317-014501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:30 20210317-013002-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:15 20210317-011501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:00 20210317-010001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 00:45 20210317-004501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 00:30 20210317-003001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 17 00:15 20210317-001501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 17 00:00 20210317-000001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:45 20210316-234502-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:30 20210316-233001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:15 20210316-231501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:00 20210316-230001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 22:45 20210316-224501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 22:30 20210316-223001-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 22:15 20210316-221501-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 22:00 20210316-220001-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 21:45 20210316-214501-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 21:30 20210316-213001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 21:15 20210316-211501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 21:00 20210316-210001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:45 20210316-204501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:30 20210316-203001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:15 20210316-201501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:00 20210316-200001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:45 20210316-194501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:30 20210316-193001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:15 20210316-191501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:00 20210316-190001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:45 20210316-184501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:30 20210316-183001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:15 20210316-181501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:00 20210316-180001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:45 20210316-174501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:30 20210316-173001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:15 20210316-171501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:00 20210316-170001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:45 20210316-164501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:30 20210316-163001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:15 20210316-161501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:00 20210316-160001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:45 20210316-154501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:30 20210316-153001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:15 20210316-151501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:00 20210316-150001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:45 20210316-144501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:30 20210316-143001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:15 20210316-141501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:00 20210316-140001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:45 20210316-134502-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:30 20210316-133001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:15 20210316-131501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:00 20210316-130002-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 12:45 20210316-124501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 12:30 20210316-123001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 12:15 20210316-121501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 12:00 20210316-120001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 11:45 20210316-114502-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 11:30 20210316-113001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 11:15 20210316-111501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 11:00 20210316-110001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 10:45 20210316-104502-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 10:30 20210316-103001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 10:15 20210316-101501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 10:00 20210316-100001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 09:45 20210316-094501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 09:30 20210316-093001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 09:15 20210316-091501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 09:00 20210316-090001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 08:45 20210316-084501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 08:30 20210316-083001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 08:15 20210316-081501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 08:00 20210316-080001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 07:45 20210316-074501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 07:30 20210316-073001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 07:15 20210316-071501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 07:00 20210316-070001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 06:45 20210316-064501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 06:30 20210316-063001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 06:15 20210316-061501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 06:00 20210316-060001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 05:45 20210316-054501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 05:30 20210316-053001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 05:15 20210316-051501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 05:00 20210316-050001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 04:45 20210316-044501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 04:30 20210316-043001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 04:15 20210316-041501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 04:00 20210316-040001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 03:45 20210316-034501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 03:30 20210316-033001-backup.tar.gz
-rw-r--r-- 1 steam steam  33M Mar 16 03:15 20210316-031501-backup.tar.gz
-rw-r--r-- 1 steam steam  33M Mar 16 03:00 20210316-030001-backup.tar.gz
-rw-r--r-- 1 steam steam  38M Mar 16 02:45 20210316-024501-backup.tar.gz
drwxr-xr-x 1 steam steam 4.0K Mar 16 02:35 ..
-rw-r--r-- 1 steam steam  38M Mar 16 02:30 20210316-023001-backup.tar.gz
-rw-r--r-- 1 steam steam  38M Mar 16 02:15 20210316-021501-backup.tar.gz
-rw-r--r-- 1 steam steam  38M Mar 16 02:00 20210316-020001-backup.tar.gz
-rw-r--r-- 1 steam steam  38M Mar 16 01:45 20210316-014501-backup.tar.gz
-rw-r--r-- 1 steam steam  38M Mar 16 01:30 20210316-013001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 01:15 20210316-011501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 01:00 20210316-010002-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 00:45 20210316-004501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 00:30 20210316-003001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 00:15 20210316-001502-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 16 00:00 20210316-000001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 23:45 20210315-234501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 23:30 20210315-233001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 23:15 20210315-231501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 23:00 20210315-230001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 22:45 20210315-224501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 22:30 20210315-223001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 22:15 20210315-221501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 22:00 20210315-220001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 21:45 20210315-214501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 21:30 20210315-213002-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 21:15 20210315-211501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 21:00 20210315-210001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 20:45 20210315-204501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 20:30 20210315-203001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 20:15 20210315-201501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 20:00 20210315-200001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 19:45 20210315-194501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 19:30 20210315-193001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 19:15 20210315-191501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 19:00 20210315-190001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 18:45 20210315-184501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 18:30 20210315-183001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 18:15 20210315-181501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 18:00 20210315-180001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 17:45 20210315-174501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 17:30 20210315-173001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 17:15 20210315-171501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 17:00 20210315-170001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 16:45 20210315-164502-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 16:30 20210315-163001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 16:15 20210315-161501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 16:00 20210315-160001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 15:45 20210315-154501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 15:30 20210315-153001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 15:15 20210315-151501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 15:00 20210315-150001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 14:45 20210315-144501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 14:30 20210315-143001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 14:15 20210315-141501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 14:00 20210315-140001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 13:45 20210315-134501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 13:30 20210315-133001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 13:15 20210315-131501-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 13:00 20210315-130001-backup.tar.gz
-rw-r--r-- 1 steam steam  37M Mar 15 12:45 20210315-124501-backup.tar.gz

After change, /home/steam/backups:

root@valheim-59978997b9-5kv96:/home/steam/backups# ls -laht
total 2.9G
-rw-r--r-- 1 steam steam  32M Mar 17 13:00 20210317-130001-backup.tar.gz
drwxr-xr-x 2 steam steam  28K Mar 17 13:00 .
-rw-r--r-- 1 steam steam  32M Mar 17 12:45 20210317-124501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:30 20210317-123001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:15 20210317-121501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 12:00 20210317-120001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:45 20210317-114501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:30 20210317-113001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:15 20210317-111501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 11:00 20210317-110001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:45 20210317-104501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:30 20210317-103001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:15 20210317-101501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 10:00 20210317-100001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:45 20210317-094501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:30 20210317-093001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:15 20210317-091501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 09:00 20210317-090001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:45 20210317-084501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:30 20210317-083001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:15 20210317-081501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 08:00 20210317-080001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:45 20210317-074501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:30 20210317-073001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:15 20210317-071501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 07:00 20210317-070001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:45 20210317-064501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:30 20210317-063001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:15 20210317-061501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 06:00 20210317-060001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:45 20210317-054501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:30 20210317-053001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:15 20210317-051501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 05:00 20210317-050001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:45 20210317-044501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:30 20210317-043001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:15 20210317-041501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 04:00 20210317-040001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:45 20210317-034501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:30 20210317-033001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:15 20210317-031501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 03:00 20210317-030001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:45 20210317-024501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:30 20210317-023002-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:15 20210317-021501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 02:00 20210317-020001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:45 20210317-014501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:30 20210317-013002-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:15 20210317-011501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 01:00 20210317-010001-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 00:45 20210317-004501-backup.tar.gz
-rw-r--r-- 1 steam steam  32M Mar 17 00:30 20210317-003001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 17 00:15 20210317-001501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 17 00:00 20210317-000001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:45 20210316-234502-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:30 20210316-233001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:15 20210316-231501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 23:00 20210316-230001-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 22:45 20210316-224501-backup.tar.gz
-rw-r--r-- 1 steam steam  31M Mar 16 22:30 20210316-223001-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 22:15 20210316-221501-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 22:00 20210316-220001-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 21:45 20210316-214501-backup.tar.gz
-rw-r--r-- 1 steam steam  30M Mar 16 21:30 20210316-213001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 21:15 20210316-211501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 21:00 20210316-210001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:45 20210316-204501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:30 20210316-203001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:15 20210316-201501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 20:00 20210316-200001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:45 20210316-194501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:30 20210316-193001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:15 20210316-191501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 19:00 20210316-190001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:45 20210316-184501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:30 20210316-183001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:15 20210316-181501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 18:00 20210316-180001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:45 20210316-174501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:30 20210316-173001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:15 20210316-171501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 17:00 20210316-170001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:45 20210316-164501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:30 20210316-163001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:15 20210316-161501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 16:00 20210316-160001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:45 20210316-154501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:30 20210316-153001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:15 20210316-151501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 15:00 20210316-150001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:45 20210316-144501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:30 20210316-143001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:15 20210316-141501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 14:00 20210316-140001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:45 20210316-134502-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:30 20210316-133001-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:15 20210316-131501-backup.tar.gz
-rw-r--r-- 1 steam steam  29M Mar 16 13:00 20210316-130002-backup.tar.gz
drwxr-xr-x 1 steam steam 4.0K Mar 16 02:35 ..

After change, logs:

==> /home/steam/valheim/logs/auto-backup.out <==
[Valheim][steam]: Starting auto backup process...
[Valheim][steam]: Removing old backups...
[Valheim][steam]: Creating backup...
[ODIN][INFO] - Run with DEBUG_MODE as 1 if you think there is an issue with Odin
[Valheim][steam]: Backup process complete! Created 20210317-130001-backup.tar.gz

Current time:

root@valheim-59978997b9-5kv96:/home/steam/backups# date
Wed Mar 17 13:02:25 +08 2021

Settings:

root@valheim-59978997b9-5kv96:/home/steam/backups# env | grep AUTO_BACKUP
AUTO_BACKUP_REMOVE_OLD=1
AUTO_BACKUP_ON_SHUTDOWN=0
AUTO_BACKUP=1
AUTO_BACKUP_ON_UPDATE=0
AUTO_BACKUP_DAYS_TO_LIVE=1
AUTO_BACKUP_SCHEDULE=*/15 * * * *

@ikaruswill ikaruswill changed the title Remove + from find -mtime Subtract 1 from AUTO_BACKUP_DAYS_TO_LIVE and prune before creating backup Mar 17, 2021
@mbround18 mbround18 self-requested a review March 17, 2021 17:22
@mbround18 mbround18 self-assigned this Mar 17, 2021
@mbround18 mbround18 added the docker Tag if its related to docker label Mar 17, 2021
@mbround18 mbround18 merged commit 7a46d27 into mbround18:main Mar 20, 2021
@ikaruswill ikaruswill deleted the fix-backup-ttl branch March 20, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbround18 mbround18 mbround18 approved these changes

Assignees

@mbround18 mbround18

Labels
docker Tag if its related to docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backups live 1 day longer than value in AUTO_BACKUP_DAYS_TO_LIVE
2 participants
@ikaruswill @mbround18