Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated env files #254

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Updated env files #254

merged 3 commits into from
Mar 5, 2021

Conversation

mbround18
Copy link
Owner

Description

Contributions

  • Env Maddness

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 added the odin Tag if theres an issue with odin label Mar 4, 2021
CosmicHorrorDev
CosmicHorrorDev requested changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not entirely clear on how this solves the issue of not sending start notifications, but I also still haven't been able to reproduce the issue. If you have any information on why this is occurring then I would really appreciate it!

src/notifications/mod.rs Outdated Show resolved Hide resolved
src/notifications/mod.rs Outdated Show resolved Hide resolved
src/utils/environment.rs Outdated Show resolved Hide resolved
CosmicHorrorDev
CosmicHorrorDev requested changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally, but everything looks good 👍

We shouldn't need to trim double-quotes if everything is handled correctly

Forgot to hit the add comment button, one sec 😭

src/files/config.rs Show resolved Hide resolved
@mbround18 mbround18 merged commit 6b721ea into main Mar 5, 2021
@mbround18 mbround18 deleted the mbround18/env-madness branch March 5, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosmicHorrorDev CosmicHorrorDev CosmicHorrorDev requested changes

Assignees

@CosmicHorrorDev CosmicHorrorDev

Labels
odin Tag if theres an issue with odin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbround18 @CosmicHorrorDev