Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added environment var catches and strengthened logic. #243

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Added environment var catches and strengthened logic. #243

merged 2 commits into from
Mar 3, 2021

Conversation

mbround18
Copy link
Owner

Description

Contributions

  • Strengthened logic
  • Added tests

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 added the odin Tag if theres an issue with odin label Mar 3, 2021
@CosmicHorrorDev
Copy link
Collaborator

Just tested locally and it looks like this does fix the issue I was having with the auto update cron job 👍

CosmicHorrorDev
CosmicHorrorDev reviewed Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the webhooks, or with mods locally, but it looks like the behavior for all those env vars should be the same.

I do like the split with fetch_var and fetch_multiple_var because it makes their usage more explicit than the boolean before!

@mbround18 mbround18 merged commit 6a30cd4 into main Mar 3, 2021
@mbround18 mbround18 deleted the mbround18/environment branch March 3, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosmicHorrorDev CosmicHorrorDev CosmicHorrorDev left review comments

Assignees
No one assigned
Labels
odin Tag if theres an issue with odin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbround18 @CosmicHorrorDev