Add in flag for updating on startup #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbround18
approved these changes
Feb 26, 2021
mbround18
added
docker
mbround18
pushed a commit
that referenced
this pull request
Feb 26, 2021
Fix missing trailing whitespace on UPDATE_ON_STARTUP #202 changes. Resolves error ```/home/steam/scripts/start_valheim.sh: line 48: [: missing `]'``` logged on container startup and makes UPDATE_ON_STARTUP run as intended.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributions
Just opening this as a possibility. A lot of people seem to expect / want the container to check for updates on startup. Beyond that there seems to be confusion regarding the manual update process.
To remedy this situation this PR adds a flag for checking for updates on startup. I set it as on by default since it seems like a lot of people expect that behavior naturally. This was going to be added with #177, but I don't see any reason why this can't be done separately. I know there was talk about update on shutdown before, but I think update on startup covers this situation better for most people.
Checklist