-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added webhook configuration and documentation updates #158
Conversation
@nogweii would you mind taking a look see? This should have plenty of information to configure and run a generic webhook as well as setting up a discord one :) |
I can do a review later tonight / tomorrow if you're fine with that, but so far everything is looking pretty good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright that's all I got. Nothing too exciting just some notices about documentation and some generic tips/questions about certain rust patterns. Feel free to let me know if you have any questions from any of it! :D
I did some work last night on getting all these changes to work, ill toss it up after I am done with work today and after I polish it up a bit. |
@LovecraftianHorror let me know whatchu think of the recent changes when you get a chance :) I broke some stuff apart bc that file was getting a bit chaunky |
It looks pretty solid to me 👍 I'm excited to use this feature, should cut down on the random discord messages on if the server is up! |
Description
See #160 for testing on this Pull Request
Contributions
Notes
Start successful does not necessarily mean Valheim actually started properly. If you run with mods or have funky issues then it will say started successfully but still bomb in console log.
However, stop successfully is a good indicator if your server saved and exited appropriately <3
Checklist