Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webhook configuration and documentation updates #158

Merged
merged 11 commits into from
Feb 26, 2021

Conversation

mbround18
Copy link
Owner

@mbround18 mbround18 commented Feb 23, 2021

Description

See #160 for testing on this Pull Request

Contributions

image

Notes

Start successful does not necessarily mean Valheim actually started properly. If you run with mods or have funky issues then it will say started successfully but still bomb in console log.

However, stop successfully is a good indicator if your server saved and exited appropriately <3

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18
Copy link
Owner Author

@CosmicHorrorDev
Copy link
Collaborator

I can do a review later tonight / tomorrow if you're fine with that, but so far everything is looking pretty good!

@mbround18 mbround18 added docker Tag if its related to docker documentation Changes only affect the documentation enhancement New feature or request odin Tag if theres an issue with odin labels Feb 23, 2021
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright that's all I got. Nothing too exciting just some notices about documentation and some generic tips/questions about certain rust patterns. Feel free to let me know if you have any questions from any of it! :D

README.md Outdated Show resolved Hide resolved
docs/odin.md Outdated Show resolved Hide resolved
docs/webhooks.md Show resolved Hide resolved
src/cli.yaml Outdated Show resolved Hide resolved
docs/webhooks.md Outdated Show resolved Hide resolved
docs/webhooks.md Show resolved Hide resolved
src/notifications/mod.rs Outdated Show resolved Hide resolved
src/notifications/mod.rs Show resolved Hide resolved
src/notifications/mod.rs Outdated Show resolved Hide resolved
src/notifications/discord.rs Outdated Show resolved Hide resolved
@mbround18
Copy link
Owner Author

I did some work last night on getting all these changes to work, ill toss it up after I am done with work today and after I polish it up a bit.

@mbround18
Copy link
Owner Author

@LovecraftianHorror let me know whatchu think of the recent changes when you get a chance :) I broke some stuff apart bc that file was getting a bit chaunky

@CosmicHorrorDev
Copy link
Collaborator

It looks pretty solid to me 👍

I'm excited to use this feature, should cut down on the random discord messages on if the server is up!

@mbround18 mbround18 merged commit bf6865e into main Feb 26, 2021
@mbround18 mbround18 deleted the mbround18/webhooks branch February 26, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Tag if its related to docker documentation Changes only affect the documentation enhancement New feature or request odin Tag if theres an issue with odin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Discord Notification through webhook
2 participants