Fix an error that makes the width value string very long.

[JongtaekChoi]

Related Issue

#2381
#2433 (not sure)

Description

columnDef.tableData.widthmay be defined even if columnDef.width is undefined.
Because the calculated tableData.width added to each column object when the props updated or added.
This function produces a string value with a previously calculated value each time it is called, so the length increases proportionally to the power of the number of columns with has undefined width.

[cdruck]

lines 87 and 88 are inconsistent

[JongtaekChoi]

@cdruck
Thanks for your review. I updated my code recently.
How about this way?

[joacub]

does not work still the bug

[joacub]

the problem is this:
OLD WRONG:

columnDef.tableData = {
        columnOrder: index,
        filterValue: columnDef.defaultFilter,
        groupOrder: columnDef.defaultGroupOrder,
        groupSort: columnDef.defaultGroupSort || 'asc',
        width: typeof columnDef.width === 'number' ? `${columnDef.width}px` : columnDef.width,
        initialWidth: typeof columnDef.width === 'number' ? `${columnDef.width}px` : columnDef.width,
        additionalWidth: 0,
        id: index,
       ...columnDef.tableData, //  <------------------------------------  Mutable data overwrite the width
      };

columnDef.tableData = {
        ...columnDef.tableData, // <------------------------------------  Now mutable data is overwrites by the next code
        columnOrder: index,
        filterValue: columnDef.defaultFilter,
        groupOrder: columnDef.defaultGroupOrder,
        groupSort: columnDef.defaultGroupSort || 'asc',
        width: typeof columnDef.width === 'number' ? `${columnDef.width}px` : columnDef.width,
        initialWidth: typeof columnDef.width === 'number' ? `${columnDef.width}px` : columnDef.width,
        additionalWidth: 0,
        id: index,
      };

[justrhysism]

I applied this patch manually and it resolved the issue from what I could see.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.