Workaround for missing has_key implementation #100
Conversation
fjetter
force-pushed
the
azure_blob/has_key
branch
from
b969715 to
dccaac1
Compare
|
cc @crepererum @byjott |
| @@ -10,5 +10,6 @@ export MINIO_ACCESS_KEY=minio | |||
| export MINIO_SECRET_KEY=miniostorage | |||
|
|
|||
| mkdir -p ~/s3 | |||
| ~/minio version | |||
|
|
|||
| ~/minio --version | |||
There was a problem hiding this comment.
This currently breaks master btw
simplekv/net/_azurestore_new.py
Outdated
| return self.blob_container_client.exists(key) | ||
| # https://github.com/Azure/azure-sdk-for-python/issues/9507 | ||
| blob_client = self.blob_container_client.get_blob_client(key) | ||
| try: |
There was a problem hiding this comment.
To mimic existing similar functions, I'd rather propose to implement it this way:
with map_azure_exceptions(key, ("BlobNotFound",)):
blob_client.get_blob_properties()
return True
return False
|
Looks to me the code is not actually tested on travis. Will investigate this... |
|
Yes, this is because the azure keys we received from microsoft are only available to pull requests from the mbr/simplekv repository. |
|
@Cornelius-Riemenschneider |
fjetter
force-pushed
the
azure_blob/has_key
branch
from
edea4f4 to
e3e3829
Compare
|
PRs from the outside shouldn't run the azure tests, no. The exact details elude me, though I believe whenever we don't have azure secrets provided to the test runner, azure tests are (silently) skipped. |
|
How to proceed with this? the new azure storage API still breaks with simplekv |
|
status on this? Can anybody merge and release this, please? |
|
If somebody gives me write access I can recreate the PR on this repo to verify the tests if this is a blocker. |
|
Replaced by #102 |
The new storage API apparently doesn't offer any exists implementation.
This is already reported on Azure/azure-sdk-for-python#9507 and they suggest a rather crude workaround...