Skip to content

Commit

Permalink
Precise issue_comment trigger
Browse files Browse the repository at this point in the history
  • Loading branch information
mbovel committed Oct 3, 2024
1 parent a1496ce commit 284e1c8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,14 @@ on:
- mb/benchmarks
issue_comment:
types: [created]
if: contains(github.event.comment.body, 'test performance please')
schedule:
# every night at 03:33
- cron: '33 3 * * *'

jobs:
benchmarks:
name: On-Push Benchmarks
if: |
github.event_name == 'push' ||
(github.event_name == 'issue_comment' && contains(github.event.comment.body, 'test performance please'))
runs-on: ['self-hosted', 'benchmarks']

steps:
Expand All @@ -35,11 +33,16 @@ jobs:
echo "/home/scalabenchs/.local/share/coursier/bin" >> $GITHUB_PATH
- name: Run Benchmarks
# Select benchmarks that do not contain `Nightly` or `Bootstrapped` in their name
# Select benchmarks that do not contain `Nightly` or `Bootstrapped` in
# their name.
# `-foe true` means "fail on error".
# `-gc true` launches the garbage collector between each iterations, which
# significantly reduces the noise.
run: "sbt 'scala3-bench / Jmh / run -foe true -gc true -e Nightly -e Bootstrapped'"

- name: Run Bootstrapped Benchmarks
# Select benchmarks that contain `Bootstrapped` in their name, but not `Nightly`
# Select benchmarks that contain `Bootstrapped` in their name, but not
# `Nightly`.
run: "sbt 'scala3-bench-bootstrapped / Jmh / run -foe true -gc true -e Nightly Bootstrapped'"

- name: Upload Results
Expand Down
2 changes: 2 additions & 0 deletions bench/src/main/scala/CompilationBenchmarks.scala
Original file line number Diff line number Diff line change
Expand Up @@ -246,5 +246,7 @@ class CompilationBenchmarks:
def implicitScopeLoop() = compile(implicitScopeLoopArgs)

// Currently crashes
// Since https://github.com/scala/scala3/pull/20195 ?
// TODO: fix and re-enable
// @Benchmark
def inductiveImplicits() = compile(inductiveImplicitsArgs)

0 comments on commit 284e1c8

Please sign in to comment.