Skip to content

Commit

Permalink
[Dataset quality] šŸž firing OPEN_FLYOUT event when flyout is initializā€¦
Browse files Browse the repository at this point in the history
ā€¦ed in URL (elastic#184495)

When moving dataset-quality instance from Observability Logs Explorer to
Stack Management > Data I left out triggering the flyout event whenever
flyout information is defined in the URL.

This PR contains a fix for the aforementioned and a change in the copy
of the DegradedDocs Improvements tooltip

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
yngrdyn and kibanamachine authored May 30, 2024
1 parent 3e44cca commit 0a8b651
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ export function DatasetQualityContextProvider({
initialState,
});
datasetQualityController.service.start();

if (initialState?.flyout?.dataset) {
datasetQualityController.service.send({
type: 'OPEN_FLYOUT',
dataset: initialState.flyout.dataset,
});
}

setController(datasetQualityController);

const datasetQualityStateSubscription = datasetQualityController.state$.subscribe((state) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ export const flyoutImprovementText = i18n.translate(
export const flyoutImprovementTooltip = i18n.translate(
'xpack.datasetQuality.flyoutDegradedFieldsSectionTooltip',
{
defaultMessage:
'Set of degraded fields in the dataset. Please not that this list may not be exhaustive.',
defaultMessage: 'A partial list of degraded fields found in your dataset.',
}
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@
*/

export * from './create_controller';
export * from './provider';
export * from './types';

This file was deleted.

0 comments on commit 0a8b651

Please sign in to comment.