Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case sensitivity fix for tagged_with #965 #990

Merged
merged 1 commit into from
May 7, 2020

Conversation

Andythurlow
Copy link
Contributor

Just a new PR for the work @endorfin did, i've cherry-picked it on top of the latest master.

It looks like @endorfin didn't see the request by @seuros to rebase the PR #966 back in October 2019.

I'm currently using a forked version with their fix, and would hopefully like to get this into master.


Original PR: #966
Original Issue: #965

Original PR comment:

arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL

arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL
@seuros seuros merged commit 47da503 into mbleigh:master May 7, 2020
rolandoalvarado pushed a commit to rolandoalvarado/acts-as-taggable-on that referenced this pull request Nov 11, 2021
arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL

Co-authored-by: René Kersten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants