Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matches_attribute was not being used in tag_match_type #871

Merged
merged 1 commit into from
Jun 1, 2018
Merged

matches_attribute was not being used in tag_match_type #871

merged 1 commit into from
Jun 1, 2018

Conversation

tekniklr
Copy link
Contributor

addresses #869

@botandrose
Copy link

I ran into #869 on upgrading to 5.0.0, and can confirm this patch fixed it for me, as well. Suggest merging, and releasing a 5.0.1?

@idoo
Copy link

idoo commented Feb 23, 2018 •
edited
Loading

it also works well for me! thanks @tekniklr
probably we need some specs for that case

@mbleigh what we can do to get it merged?

@seuros seuros merged commit 6d04533 into mbleigh:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tekniklr @botandrose @idoo @seuros