Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context constraint to find_related_* methods. #629

Merged
merged 1 commit into from
Feb 11, 2015

Conversation

d4rky-pl
Copy link
Contributor

Fix for issue #628
(I'm terribly sorry for the mess, I keep forgetting it's impossible to convert issue into pull request)

@seuros
Copy link
Collaborator

seuros commented Feb 10, 2015

could you add a test for this ?

@d4rky-pl
Copy link
Contributor Author

Test added

@seuros
Copy link
Collaborator

seuros commented Feb 10, 2015

Could you squash the commits ?

@d4rky-pl d4rky-pl force-pushed the fix-find_related_tags-for-contexts branch from 3a77fbf to 3f9632a Compare February 11, 2015 08:41
@d4rky-pl
Copy link
Contributor Author

done

seuros added a commit that referenced this pull request Feb 11, 2015
Add context constraint to find_related_* methods.
@seuros seuros merged commit a144a29 into mbleigh:master Feb 11, 2015
@seuros
Copy link
Collaborator

seuros commented Feb 11, 2015

💚

@d4rky-pl
Copy link
Contributor Author

I would be very grateful for releasing a new minor version with this fix as it's affecting my client's important part of project.

@seuros
Copy link
Collaborator

seuros commented Feb 11, 2015

Will do

@d4rky-pl
Copy link
Contributor Author

@seuros any idea when? ;)

@seuros
Copy link
Collaborator

seuros commented Feb 11, 2015

Sorry for delay. Tagged and released.

tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
…r-contexts

Add context constraint to find_related_* methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants