-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context constraint to find_related_* methods. #629
Merged
seuros
merged 1 commit into
mbleigh:master
from
d4rky-pl:fix-find_related_tags-for-contexts
Feb 11, 2015
Merged
Add context constraint to find_related_* methods. #629
seuros
merged 1 commit into
mbleigh:master
from
d4rky-pl:fix-find_related_tags-for-contexts
Feb 11, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could you add a test for this ? |
Test added |
Could you squash the commits ? |
d4rky-pl
force-pushed
the
fix-find_related_tags-for-contexts
branch
from
February 11, 2015 08:41
3a77fbf
to
3f9632a
Compare
done |
seuros
added a commit
that referenced
this pull request
Feb 11, 2015
Add context constraint to find_related_* methods.
💚 |
I would be very grateful for releasing a new minor version with this fix as it's affecting my client's important part of project. |
Will do |
@seuros any idea when? ;) |
Sorry for delay. Tagged and released. |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
…r-contexts Add context constraint to find_related_* methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #628
(I'm terribly sorry for the mess, I keep forgetting it's impossible to convert issue into pull request)