Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing mattr_accessor require, README test info #410

Merged
merged 1 commit into from
Dec 10, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ directory, you can run the specs with:

```shell
bundle
cp spec/database.yml{.sample,}
rake spec
```

Expand Down
1 change: 1 addition & 0 deletions lib/acts-as-taggable-on.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require "active_record"
require "active_record/version"
require "active_support/core_ext/module"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is no longer necessary due to the full-on require of AS below. However, it would be better to be granular, so I'm ok with this.

require "action_view"
require 'active_support/all'

Expand Down