Improved performance with counter_cache for tags (tag.taggings_count)

[h0jeZvgoxFepBQ2C]

Improved performance with counter_cache for tags (tag.taggings_count)

[bitflorist]

will this be accepted? This would be great!

[dgilperez]

I implemented the same improvement in my local fork.

dgilperez@bb8c8d3

So goes my +1 to this feature !!!

[jaimeiniesta]

This would be great for performance reasons, here goes my +1

[artemk]

I wonder if adding counter_cache won't break existing apps, which don't want to rerun migrations are add new one.

[jaimeiniesta]

Good point @artemk - the migration that adds the counter_cache column should set the current value for the existing tags, if not, it will be set to 0, which is the default.

[artemk]

Do you know a way how to generate new migration on bundle update ?

[jaimeiniesta]

I think that running a migration on bundle update is not desirable, this should be executed manually by the user.

Instead, I would put this new columns on the acts_as_taggable_on:migration generator, so it's all set up on new projects; for existing ones, I would offer a separate rake task that updates the existing data, like "rake acts_as_taggable_on:update_counters", and tell users to do that on the README.

[dgilperez]

I agree with @jaimeiniesta on that.

[artemk]

Do you read readme every time you update your bundle?

[jaimeiniesta]

I do, and I never update the entire bundle at once, only every individual gem, checking what's new and what needs updating.

It's just not a good idea to modify the user's database automatically, that's dangerous. It should be done by the users.

[rromanchuk]

+1, hi @jaimeiniesta :)

[rromanchuk]

@lichtamberg it would awesome if you had time to update the README file too. There is no mention of caching, would be nice if people didn't have to dig around.

[diegorv]

+1 :D

[brookr]

Uh oh, a 2 year old pull request... Does it still have any hope… or relevancy?

[dgilperez]

Well, I keep my branch updated against master, only to have this feature included.

https://github.com/dgilperez/acts-as-taggable-on

I still think this would be a great thing to have.

[iamjoshua]

+1 Seriously, how has this not been added yet...

[tilsammans]

I love this pull request and would like it resubmitted (I am the new maintainer).

Because we're asking people to run an "update migration" I think this PR should target version 3.0.0. Because there are a lot of issues still waiting to be fixed, it will be a while before we can make that happen. I would say at least three months away.

Is everyone on board with it? If so, please exercise a little patience while I try to fix actual breakage first.

Ideally the new migration also includes #343 and we can work with an updated schema during the entire 3.x branch.