Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non rollbackable tenant migration #1038

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Jun 17, 2021

If you remove a column, the indexes are by default also removed
Thus this migration causes following if we try to rollback
image

2 possible solutions:
remove the remove_index or move it up

I chose the latter so up and down are symmetric, it's more esthetic and explicit.

@seuros seuros merged commit 4a7948e into mbleigh:master Jun 17, 2021
@seuros
Copy link
Collaborator

seuros commented Jun 17, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants