Fix tests to cover uncovered branches #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit solves the coverage drop from: - #23 01a79f6 Restores `istanbul` as the coverage reporter for the JSDom-based CI run to restore consistency in reporting, particularly in Coveralls. --- Adapted from the new test/missing-app-div/jsdom.test.js: Moved the "missing #app div" test into a separate directory from the other tests in ../jsdom.test.js. to prevent Node.js from using the same `test-modules/main.js` import. Otherwise: - If the test case were in the same file, the "missing #app div" branch wouldn't execute and the test would fail. - If this test file were in the same directory, the Istanbul coverage reporter wouldn't see the coverage from the "missing #app div" branch. I don't know exactly why that is. At the same time, the previous `src="./main.js?version=missing"` query suffix is no longer necessary. I got the idea to organize the tests this way after successfully covering similar code in: - mbland/tomcat-servlet-testing-example#85 mbland/tomcat-servlet-testing-example@b5df30e
Pull Request Test Coverage Report for Build 7548603948
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit solves the coverage drop from:
Restores
istanbulas the coverage reporter for the JSDom-based CI run to restore consistency in reporting, particularly in Coveralls.Adapted from the new test/missing-app-div/jsdom.test.js:
Moved the "missing #app div" test into a separate directory from the other tests in ../jsdom.test.js. to prevent Node.js from using the same
test-modules/main.jsimport. Otherwise:If the test case were in the same file, the "missing #app div" branch wouldn't execute and the test would fail.
If this test file were in the same directory, the Istanbul coverage reporter wouldn't see the coverage from the "missing #app div" branch. I don't know exactly why that is.
At the same time, the previous
src="./main.js?version=missing"query suffix is no longer necessary.I got the idea to organize the tests this way after successfully covering similar code in: