bats/helpers: Add create_forwarding_script #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the functions listed #186 as a candidate for migration from `tests/template.bats`. I realized it would be helpful to have this function while migrating the assertions from `tests/scripts/serve.bats` in mbland/custom-links per #181. This commit contains two additional changes: It removes the `--in-process` option from `stub_program_in_path`. It turns out I wasn't using that option anywhere, and I couldn't make any tests fail because it didn't have an effect anyway, since the `run` function from Bats always launches its arguments in a new subshell. `restore_program_in_path` now strips `BATS_TEST_BINDIR` from the beginning of `PATH`.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the functions listed #186 as a candidate for migration from
tests/template.bats. I realized it would be helpful to have this function while migrating the assertions fromtests/scripts/serve.batsin mbland/custom-links per #181.This commit contains two additional changes:
It removes the
--in-processoption fromstub_program_in_path. It turns out I wasn't using that option anywhere, and I couldn't make any tests fail because it didn't have an effect anyway, since therunfunction from Bats always launches its arguments in a new subshell.restore_program_in_pathnow stripsBATS_TEST_BINDIRfrom the beginning ofPATH.