Explicitly require dependencies to avoid ordering issues #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue attempting to use the master version (which fixes a comparison bug we were having in 0.6.0) where the order of files being loaded in
lib/equivalent-xml.rb
was inconsistent. This leads to an issue when requiring the gem:Dir[File.expand_path('../equivalent-xml/proxy/*',__FILE__)]
seems to return an array of paths in an unintended order. This causes the subclasses to load before the super class, which resultsin EquivalentXml::Proxy::Base being undefined.
On my machine it will load in the order:
I've changed the requires to be more explicit, each subclass now requires the base class, and
lib/equivalent-xml.rb
requires each of the subclasses. It's possible you're not keen on this approach, but I thought I would propose it to see what you thought.