Here are two minor bug fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the location of the plug-ins in the Mulberry project to be based on BUILT_PRODUCTS_DIR instead of instead of SOURCE_ROOT. This makes the project work regardless of the setting of the "Build Location" XCode preference. In order to make this work for both Debug and Release builds of the main project, Release builds were added to each plug-in project. Some other changes were made by XCode 4 on its own.
This is needed to make the build work when the XCode "Build Location" preference is set to "Location Specified by Targets". More importantly the command line tool ignores this preference and always acts as if it is on. As a beneficial side effect, all the build directories in the Plug-ins directory disappear.
It returns true only if the map is not empty.
Mulberry handles the 401 authentication failure response and gets credentials when necessary, but this doesn't work right with some WEBDAV servers. As a work around get credentials before the first transaction.
It returns true only if the map is not empty.
Mulberry handles the 401 authentication failure response and gets credentials when necessary, but this doesn't work right with some WEBDAV servers. As a work around get credentials before the first transaction.
…nd local project state.
…it a submodule. Add new files from upstream to VC10 project.
…ntainer::ConstructSearch().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two minor bug fixes in the preferences code. The IsEmpty method is currently unused but when I tried to use it (on a dead end that I since rejected) I discovered that it doesn't work.
The other change fixes things if you store preferences on certain WEBDAV servers. I'm switching to a2hosting.com for my hosting service and I discovered that their WEBDAV server doesn't require authentication for the initial OPTIONS request, and when it responds to the following GET request with a 401 failure it disconnects before Mulberry can do anything about it. I don't know if this is a Mulberry or a server problem (my guess is server), but getting authentication credentials before the OPTIONS request fixes it.
I suspect similar changes should be made to the other WEBDAV based modules but I don't have any easy way to test that.
I'm a novice at using github pull requests. Let me know if there is a problem with this one.