Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIMXRT105x serial_format() not working #134

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

This applies the patch found in this issue: ARMmbed#15342 . The code for MIMRT serial_format() was obviously broken as it is using a uint8_t to store the 32-bit CTRL register:
image

Impact of changes

serial_format() was obviously broken on MIMXRT105x targets.

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Was tested by @grumpyengineer in their issue.


Reviewers


@multiplemonomials multiplemonomials changed the title Fix MIMXRT serial_format() not working Fix MIMXRT105x serial_format() not working Feb 18, 2023
@multiplemonomials multiplemonomials merged commit 7d9ab3f into master Feb 18, 2023
@multiplemonomials multiplemonomials deleted the bugfix/mimxrt-serial-format branch February 18, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants