Screenshots resize #369
Merged
Screenshots resize #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've resized all the screenshots to a fixed size of 600x300, that is an average (almost) of all the original files.
I'm thinking to a better solution for the long run, but in the meanwhile I can submit, from time to time, a PR while the resized screenshots.
I've done the resize using ImageMagick:
And moved the new files back in the screenshots folder.
A brief digression
Screenshots should be generated always using the same tool, with the same options, this is to assure that they all look the same.
I'm investigating on this, and I'll let you know which options we have (if any).