Merge pull request #26 from mb706/warnfix

handle error -> warning conversion correctly
mb706 · Jul 30, 2024 · df43bae · df43bae
2 parents f7ab87b + 475f3d2
commit df43bae
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -44,7 +44,7 @@ Suggests:
 LazyData: yes
 Roxygen: list(markdown = TRUE, r6 = FALSE)
 ByteCompile: yes
-Version: 0.5.1-9000
+Version: 0.5.1-2
 RoxygenNote: 7.3.1
 Collate: 
     'utils.R'

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+# mlrintermbo 0.5.1-2
+  - minor bugfix: converting errors to warnings did not work when inside `try()`.
+
 # mlrintermbo 0.5.1-1
   - compatibility with upcoming bbotk release
 

diff --git a/R/optimize.R b/R/optimize.R
@@ -84,7 +84,7 @@ See https://github.com/mlr-org/mlrMBO/issues/474")
       TRUE
     }, error = function(e) {
       if (self$on.surrogate.error == "stop") stop(e)
-      if (self$on.surrogate.error == "warn") warning(e)
+      if (self$on.surrogate.error == "warn") warning(warningCondition(conditionMessage(e), call = conditionCall(e)))
       if (still.needs.proposition) {
         instance$eval_batch(generate_design_lhs(instance$search_space, 1)$data)  # evaluate a random point
         FALSE