Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator function to detect malformed cidrs #80

Open
mayn opened this issue Oct 17, 2017 · 0 comments
Open

validator function to detect malformed cidrs #80

mayn opened this issue Oct 17, 2017 · 0 comments
Labels
easy enhancement

Comments

@mayn
Copy link
Owner

mayn commented Oct 17, 2017

Expected behavior

there should be a validator that will check strings for cidr values and throw a validation error if the correct cidr format isn't specified

once created, cidr attributes should be updated to use the validator

Actual behavior

currently we only pass through str values to the template

Steps to reproduce

should be able to define a builder with a cidr attribute and call builder.to_dict() similar to how the tests currently detect a validation error
stevelle added a commit to stevelle/packerlicious that referenced this issue Oct 19, 2017
@stevelle
Add ip network (cidr) validation
3604cf3 
Uses a backport of the Python 3.3 ipaddress library
for Python 2.x implementation.

Fixes mayn#80
@stevelle stevelle mentioned this issue Oct 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ip network (cidr) validation stevelle/packerlicious
1 participant
@mayn