✨ [#100] Add ConfigurationStep for Service model #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
changed the title
stevenbal
changed the title
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
3 times, most recently
from
7541613 to
62cb25c
Compare
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
4 times, most recently
from
85b7850 to
fb28f8a
Compare
stevenbal
commented
Nov 12, 2024
|
@swrichards I think this is ready for a first review, though we'll probably keep it in draft until it's functional in a PR in another project (Open Forms for example)? |
stevenbal
commented
Nov 12, 2024
Comment on lines
+8
to
+10
| # TODO these should probably be defined in simple_certmanager and referred to? | ||
| # client_certificate: FilePath = DjangoModelRef(Service, "client_certificate") | ||
| # server_certificate: FilePath = DjangoModelRef(Service, "server_certificate") |
There was a problem hiding this comment.
I'm checking with Sjoerd if Dimpact uses these currently, if not this might be something for later
There was a problem hiding this comment.
Sjoerd told me that Dimpact doesn't use this currently, so I'm leaving this out of scope for now
stevenbal
commented
Nov 12, 2024
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
2 times, most recently
from
59b2602 to
5af30fd
Compare
stevenbal
commented
Nov 15, 2024
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
from
5af30fd to
7f0c147
Compare
Merged
9 tasks
sergei-maertens
approved these changes
Nov 18, 2024
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
3 times, most recently
from
6bb68b2 to
f6cdb10
Compare
|
@sergei-maertens added tests for this and also added |
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
2 times, most recently
from
adef24a to
f81f32d
Compare
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
4 times, most recently
from
e749ac4 to
79b917c
Compare
swrichards
requested changes
Nov 25, 2024
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
3 times, most recently
from
bcfa9f2 to
d260acb
Compare
which can load any number of Services, configured in a YAML file
* use lowercase for root level keys in YAML files (e.g. `zgw_consumers_config_enable`) * use `identifier` instead of `slug` in config files * add `setup_config_` prefix to test files * remove `is_configured` and `validate_result`
and add a test for idempotency
stevenbal
force-pushed
the
feature/django-setup-configuration
branch
from
d260acb to
2e4516a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
django-setup-configurationas an optional dependency viapip install zgw-consumers[setup-configuration]ServiceConfigurationStepthat can be reused in projects that use zgw-consumers