-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#197] Klanten API migration command #263
Conversation
src/openklant/tests/fixtures/migrate_command/cassettes/digitaal_adres.yaml
Outdated
Show resolved
Hide resolved
Looks good overall, I think it might also be good to add some basic documentation on how to use this command to the docs |
4d71766
to
01f7acc
Compare
@SonnyBA I haven't worked on this yet, since I've spent most of my time on zgw consumers upgrade for Open Zaak. Could you pick up the feedback for this PR? |
Refinement: Waiting for @SonnyBA to get better. If not this week, @annashamray will pick it up. |
0b18997
to
423ed1a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 96.89% 96.72% -0.17%
==========================================
Files 146 167 +21
Lines 6444 7668 +1224
==========================================
+ Hits 6244 7417 +1173
- Misses 200 251 +51 ☔ View full report in Codecov by Sentry. |
@stevenbal I moved code from the management command file to the |
This can act as a remote server which serves subject data.
This is now done at an earlier stage, see `_retrieve_klanten`
2ba249b
to
61d0b4e
Compare
@SonnyBA please round up this PR and release a new version of Open Klant with in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions/remarks, otherwise it looks good 👍
Co-authored-by: Steven Bal <[email protected]>
Co-authored-by: Steven Bal <[email protected]>
One page for users and one for developers
docs/installation/migration.rst
Outdated
|
||
An example of how one might want to run this command can be seen below: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one remark about docs formatting, otherwise good to merge for me 👍
Fixes #197
Changes
Adds a management command which allows the migration of the previous Klanten API to the Klantinteracties API. Two running instances (Klanten and Klantinteracties API) are required to do so with an API token for the Klanten API.