Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2045] Add regression test for e-suite missing statuses #987

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jan 24, 2024

Regression test for Taiga issue #2037 (PR 981)

Taiga: 2045

@pi-sigma pi-sigma changed the title [#2046] Add regression test for e-suite missing statuses [#2045] Add regression test for e-suite missing statuses Jan 24, 2024
@pi-sigma pi-sigma force-pushed the cleanup/statuses-regression-test branch 2 times, most recently from a431a6e to f87bbac Compare January 24, 2024 11:09
@pi-sigma pi-sigma marked this pull request as ready for review January 24, 2024 11:31
@pi-sigma pi-sigma requested a review from stevenbal January 24, 2024 12:46
@@ -877,6 +877,46 @@ def test_document_ordering_by_name(self, m):
self.assertEqual(documents[1].name, "uploaded_document_title.txt")
self.assertEqual(documents[2].name, "yet_another_document_title.txt")

@patch("open_inwoner.cms.cases.views.status.fetch_status_history")
def test_e_suite_missing_current_status(self, m, mock_fetch_status_history):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the original issue (https://taiga.maykinmedia.nl/project/open-inwoner/issue/2037) is specifically about the upload button not showing (because InnerCaseDetailView.is_file_upload_enabled_for_statustype was returning False due to the statustype not being resolved) , I think it would be good to add checks for that here as well

@pi-sigma pi-sigma force-pushed the cleanup/statuses-regression-test branch from f87bbac to 3c08798 Compare January 25, 2024 10:53
@pi-sigma pi-sigma force-pushed the cleanup/statuses-regression-test branch from 3c08798 to d3b63ca Compare January 25, 2024 11:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3d539f) 94.76% compared to head (d3b63ca) 94.76%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #987   +/-   ##
========================================
  Coverage    94.76%   94.76%           
========================================
  Files          861      861           
  Lines        30202    30228   +26     
========================================
+ Hits         28620    28646   +26     
  Misses        1582     1582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma requested a review from stevenbal January 25, 2024 12:28
@stevenbal stevenbal merged commit e0528fc into develop Jan 25, 2024
14 checks passed
@stevenbal stevenbal deleted the cleanup/statuses-regression-test branch January 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants