Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1979] Change date captions for cases list as design #959

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jan 15, 2024

issue https://taiga.maykinmedia.nl/project/open-inwoner/task/1979
Dates in case list were not put in the positions they needed to be, so now put conforming to design (closely aligned to the Case title)
And: also improved some of the Card paddings according to design + changed the name of the gray variant to a "contextual" name that is more commonly used by designers and with design-tokens ('900' instead of '90').

Link to design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=1%3A273&mode=design&t=PfzsswiRMAp5biaL-1

@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch from 0fe8c7c to 243b236 Compare January 16, 2024 09:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcfa399) 94.75% compared to head (9e4b325) 94.75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #959   +/-   ##
========================================
  Coverage    94.75%   94.75%           
========================================
  Files          869      869           
  Lines        30288    30288           
========================================
  Hits         28698    28698           
  Misses        1590     1590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch 3 times, most recently from d2d63c8 to 5d03d30 Compare January 18, 2024 16:32
@jiromaykin jiromaykin marked this pull request as ready for review January 18, 2024 16:32
@jiromaykin jiromaykin requested a review from pi-sigma January 18, 2024 16:33
src/open_inwoner/cms/cases/tests/test_htmx.py Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/cases/list_inner.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/cases/list_inner.html Outdated Show resolved Hide resolved
@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch 2 times, most recently from 4507978 to 9bad092 Compare January 22, 2024 17:21
@jiromaykin jiromaykin requested a review from pi-sigma January 22, 2024 17:22
@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch from 90b3893 to d910143 Compare January 22, 2024 17:36
@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch 3 times, most recently from 0fea870 to c1f11bb Compare January 29, 2024 15:27
@jiromaykin jiromaykin requested a review from pi-sigma January 29, 2024 16:10
@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch from c1f11bb to 5adbb6e Compare January 30, 2024 09:17
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the date has been moved closer to the title, the distance between two lines of a multi-line title is bigger than the distance between title and date. Should we change this?

Screenshot from 2024-01-30 10-33-37

@jiromaykin jiromaykin force-pushed the feature/1979-cases-list-date-design branch from 9ab9659 to 9e4b325 Compare January 30, 2024 10:39
@jiromaykin jiromaykin requested a review from pi-sigma January 30, 2024 11:48
@jiromaykin
Copy link
Contributor Author

Now that the date has been moved closer to the title, the distance between two lines of a multi-line title is bigger...

I have changed the line-height and changed the default text for open submissions button.

@alextreme alextreme merged commit c5784fd into develop Feb 1, 2024
14 checks passed
@alextreme alextreme deleted the feature/1979-cases-list-date-design branch February 1, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants