Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1978] Make uploadbutton and title show only when files are selected #943

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jan 9, 2024

Issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1978

  1. upload button must be invisible at first, + 'geselecteerde bestanden' must be invisible.
  2. upload button becomes visible when file(s) are selected, + 'geselecteerde bestanden' becomes visible.
  3. visible upload button becomes disabled if data-max-file-size is exceeded, but becomes enabled again when those selected files are removed with trash button.
Screenshot 2024-01-09 at 18 00 53

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca8f7ab) 93.07% compared to head (575860d) 93.07%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #943   +/-   ##
========================================
  Coverage    93.07%   93.07%           
========================================
  Files          828      828           
  Lines        28995    28995           
========================================
  Hits         26988    26988           
  Misses        2007     2007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the fix/1978-make-uploadbutton-show-after-selected branch 2 times, most recently from 2e0fc04 to a84ee86 Compare January 11, 2024 11:43
@jiromaykin jiromaykin force-pushed the fix/1978-make-uploadbutton-show-after-selected branch from 8ba3184 to 6a2927d Compare January 11, 2024 12:00
@jiromaykin jiromaykin marked this pull request as ready for review January 11, 2024 12:02
@alextreme alextreme merged commit 0574504 into develop Jan 12, 2024
14 checks passed
@alextreme alextreme deleted the fix/1978-make-uploadbutton-show-after-selected branch January 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants