-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#1949] Mijn aanvragen filtering by vestigingsnummer #928
✨ [#1949] Mijn aanvragen filtering by vestigingsnummer #928
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
+ Coverage 93.01% 93.03% +0.02%
===========================================
Files 826 827 +1
Lines 28672 28781 +109
===========================================
+ Hits 26668 26776 +108
- Misses 2004 2005 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however could we move request.session.get("KVK_BRANCH_NUMBER")
to a utility function? We're going to need this session-value more often so it feels worthwhile to avoid duplicating this constant
062c352
to
d3b662c
Compare
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1949