Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#1949] Mijn aanvragen filtering by vestigingsnummer #928

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 4, 2024

@stevenbal stevenbal marked this pull request as draft January 4, 2024 13:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bd53fd2) 93.01% compared to head (d3b662c) 93.03%.
Report is 3 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/openzaak/cases.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #928      +/-   ##
===========================================
+ Coverage    93.01%   93.03%   +0.02%     
===========================================
  Files          826      827       +1     
  Lines        28672    28781     +109     
===========================================
+ Hits         26668    26776     +108     
- Misses        2004     2005       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal marked this pull request as ready for review January 4, 2024 15:04
@stevenbal stevenbal requested a review from alextreme January 4, 2024 15:12
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however could we move request.session.get("KVK_BRANCH_NUMBER") to a utility function? We're going to need this session-value more often so it feels worthwhile to avoid duplicating this constant

@stevenbal stevenbal requested a review from alextreme January 5, 2024 08:43
@stevenbal stevenbal force-pushed the feature/1949-mijn-aanvragen-vestigingsnummer branch from 062c352 to d3b662c Compare January 5, 2024 08:48
@stevenbal stevenbal merged commit b3fa2d0 into develop Jan 5, 2024
14 checks passed
@stevenbal stevenbal deleted the feature/1949-mijn-aanvragen-vestigingsnummer branch January 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants