Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💬 [#1946] More specific message for onderwerpen page 403 #920

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal force-pushed the issue/1946-onderwerp-permission-denied-msg branch from 32dcbed to 9375286 Compare January 2, 2024 10:14
@stevenbal stevenbal requested a review from alextreme January 2, 2024 10:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d64f1b) 92.96% compared to head (9375286) 92.96%.
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #920   +/-   ##
========================================
  Coverage    92.96%   92.96%           
========================================
  Files          820      820           
  Lines        28392    28400    +8     
========================================
+ Hits         26394    26402    +8     
  Misses        1998     1998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -160,6 +160,13 @@ def display_restricted(self):
and config.hide_categories_from_anonymous_users
)

def get_permission_denied_message(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standaard gedrag van Django is volgens mij dat dit anders een empty string wordt, dus prima

@alextreme alextreme merged commit 1dda63d into develop Jan 2, 2024
14 checks passed
@alextreme alextreme deleted the issue/1946-onderwerp-permission-denied-msg branch January 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants