Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1764] Limit haalcentraal api requests to subset of available fields #905

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

pi-sigma
Copy link
Contributor

Taiga #1764

@pi-sigma
Copy link
Contributor Author

I'm not sure that my changes to the mock are entirely correct. When I curl the BRP API with the selected fields (Docker setup, see here) I get the following response:

{
   "type":"RaadpleegMetBurgerservicenummer",
   "personen":[
      {
         "geslacht":{
            "code":"V"
         },
         "naam":{
            "voornamen":"Suzanne",
            "geslachtsnaam":"Moulin",
            "voorletters":"S."
         },
         "geboorte":{
            "plaats":{
               "omschrijving":"Thann"
            },
            "datum":{
               "type":"Datum",
               "datum":"1985-12-01",
               "langFormaat":"1 december 1985"
            }
         },
         "verblijfplaats":{
            "type":"Adres",
            "verblijfadres":{
               "officieleStraatnaam":"Boterdiep",
               "huisnummer":31,
               "postcode":"3077AW",
               "woonplaats":"Rotterdam"
            }
         }
      }
   ]
}

Some of the data is filtered out as intended (geboorte.plaats is correct), but other superfluous stuff is still there (geboorte.datum.langFormaat). The validity of the data needs to be checked on the test environment.

@pi-sigma pi-sigma force-pushed the feature/1764-haalcentraal-data branch from 505ed49 to 00aff2b Compare December 14, 2023 14:56
@pi-sigma pi-sigma force-pushed the feature/1764-haalcentraal-data branch from 00aff2b to 1bdbeae Compare December 18, 2023 07:40
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cac5a4) 92.93% compared to head (a4391f8) 92.93%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    92.93%   92.93%           
========================================
  Files          819      819           
  Lines        28250    28250           
========================================
  Hits         26255    26255           
  Misses        1995     1995           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review December 18, 2023 07:55
@alextreme alextreme merged commit 1d05ead into develop Dec 19, 2023
14 checks passed
@alextreme alextreme deleted the feature/1764-haalcentraal-data branch December 19, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants