Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#1938] Expand allowed CSS properties to NLDS CSS variables #899

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Dec 12, 2023

Read extensive issue here: https://taiga.maykinmedia.nl/project/open-inwoner/task/1938

CSS code generated comes from the 'dist' folder from other Repository here: https://github.com/maykinmedia/open-inwoner-design-tokens

@jiromaykin jiromaykin force-pushed the feature/1938-add-admin-field-for-NLDS-CSS-variables branch from 85efba3 to b1719bc Compare December 12, 2023 14:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d9743b) 92.81% compared to head (584f1a1) 92.91%.
Report is 40 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #899      +/-   ##
===========================================
+ Coverage    92.81%   92.91%   +0.09%     
===========================================
  Files          803      817      +14     
  Lines        27536    28036     +500     
===========================================
+ Hits         25558    26049     +491     
- Misses        1978     1987       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/1938-add-admin-field-for-NLDS-CSS-variables branch from e9621af to aa3a934 Compare December 14, 2023 17:01
@jiromaykin jiromaykin force-pushed the feature/1938-add-admin-field-for-NLDS-CSS-variables branch from 9d63f37 to 584f1a1 Compare December 18, 2023 14:09
@jiromaykin
Copy link
Contributor Author

This attempt is now obsolete due to PR #911

@jiromaykin jiromaykin closed this Dec 19, 2023
@jiromaykin jiromaykin deleted the feature/1938-add-admin-field-for-NLDS-CSS-variables branch December 19, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants