Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#1904] Fix status notification for duplicate configs #882

Merged

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal requested a review from pi-sigma December 7, 2023 09:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3bc521) 92.81% compared to head (2ff7285) 92.81%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #882   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files          802      802           
  Lines        27525    27530    +5     
========================================
+ Hits         25547    25552    +5     
  Misses        1978     1978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme
Copy link
Member

This issue will require backporting to 1.12 (as otherwise OIP won't be sending notifications)

@alextreme alextreme merged commit c243c0a into develop Dec 11, 2023
14 checks passed
@alextreme alextreme deleted the issue/1904-notification-duplicate-statustypeconfig branch December 11, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants